fix: parse fractional seconds in ChronosTime as a fraction of a second
ChronosTime::parseString() passed the fractional-seconds digits straight to (int), so a short fraction such as .5 was read as 5 microseconds instead of 500000 (half a second), diverging from DateTime. Right-pad the fractional digits to microseconds before converting.
This commit is contained in:
1 parent
760a3e72b1
commit
49dbcb8c91
2 files changed
+16
-1
No files matched your search
+3
-1
@@ -122,7 +122,9 @@ class ChronosTime implements Stringable
|
||||
$hours = (int)$matches[1];
|
||||
$minutes = (int)$matches[2];
|
||||
$seconds = (int)($matches[3] ?? 0);
|
||||
$microseconds = (int)substr($matches[4] ?? '', 0, 6);
|
||||
// The fraction is of a second, so pad on the right to microseconds:
|
||||
// without it ".5" reads as 5us instead of 500000 (half a second).
|
||||
$microseconds = (int)str_pad(substr($matches[4] ?? '', 0, 6), 6, '0', STR_PAD_RIGHT);
|
||||
|
||||
if ($hours > 24 || $minutes > 59 || $seconds > 59 || $microseconds > 999_999) {
|
||||
throw new InvalidArgumentException(sprintf('Time string `%s` contains invalid values.', $time));
|
||||
|
||||
Reference in new issue
Block a user