Commit Graph
6 Commits
Author SHA1 Message Date
dualfroz df951c01eb partially fix #4012: migrate: mention snapshots referencing a local ISO image
When a VM has no local ISO image attached anymore, but one of its
snapshots still references it, migration fails with:

  can't migrate local disk 'local:iso/debian.iso': local cdrom image

which does not tell where the image is coming from, since it is not
visible in the current configuration of the VM.

Add the names of the snapshots referencing the image to the error in
that case, like it is already done for a physical CD/DVD drive. The
check for the physical drive now reuses the same hint, which also
uses the plural form if more than one snapshot references it.

Add a migration test with an ISO image on the 'local' storage that is
only referenced in a snapshot. This requires the 'iso' content type
for the 'local' storage in the test.

Signed-off-by: Michal Fox <me@dualfroz.com>
Link: https://lore.proxmox.com/20261008094650.7-3-me@dualfroz.com
[FE: note that it's a partial fix as the UI still needs to be improved]
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2026-10-09 16:31:29 +02:00
upstream 89276a207f Upstream proxmox-git/qemu-server state of the touched files before a4efa5f9ad 2026-10-08 09:46:50 +00:00
dualfroz 55a24d220e fix #4012: migrate: mention snapshots referencing a local ISO image
When a VM has no local ISO image attached anymore, but one of its
snapshots still references it, migration fails with:

  can't migrate local disk 'local:iso/debian.iso': local cdrom image

which does not tell where the image is coming from, since it is not
visible in the current configuration of the VM.

Add the names of the snapshots referencing the image to the error in
that case, like it is already done for a physical CD/DVD drive. The
check for the physical drive now reuses the same hint, which also
uses the plural form if more than one snapshot references it.

Add a migration test with an ISO image on the 'local' storage that is
only referenced in a snapshot. This requires the 'iso' content type
for the 'local' storage in the test.

Signed-off-by: Michal Fox <me@dualfroz.com>
2026-10-08 01:28:21 +02:00
upstream 2b5f393932 Upstream proxmox-git/qemu-server state of the touched files before 6f34dddd1c 2026-10-08 01:28:21 +02:00
dualfroz fed54ce52a fix #4012: migrate: mention snapshots referencing a local ISO image
When a VM has no local ISO image attached anymore, but one of its
snapshots still references it, migration fails with:

  can't migrate local disk 'local:iso/debian.iso': local cdrom image

which does not tell where the image is coming from, since it is not
visible in the current configuration of the VM.

Add the names of the snapshots referencing the image to the error in
that case, like it is already done for a physical CD/DVD drive. The
check for the physical drive now reuses the same hint.

Signed-off-by: Michal Fox <me@dualfroz.com>
2026-10-03 01:44:51 +02:00
upstream 5fa8c46714 Upstream proxmox-git/qemu-server state of the touched files before eb22d44aeb 2026-10-03 01:44:51 +02:00